Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Test probe load with mocks #1991

Merged
merged 4 commits into from
Mar 15, 2025
Merged

Test probe load with mocks #1991

merged 4 commits into from
Mar 15, 2025

Conversation

MrAlias
Copy link
Contributor

@MrAlias MrAlias commented Mar 14, 2025 •
edited
Loading

  • Use a real compiled Go binary running process to simulate real allocation and process identification behavior
  • Remove the build flag so tooling finds the test file during normal development (skip the test if not able to run)
  • Flatten the testutils package into the only place it is used

@MrAlias MrAlias mentioned this pull request Mar 14, 2025
Open
@MrAlias MrAlias force-pushed the test-load-with-mocks branch 2 times, most recently from 1ab6d25 to cd5fa3a Compare March 14, 2025 21:27
@MrAlias MrAlias changed the title Test load with mocks Test prove load with mocks Mar 14, 2025
@MrAlias MrAlias changed the title Test prove load with mocks Test probe load with mocks Mar 14, 2025
@MrAlias MrAlias force-pushed the test-load-with-mocks branch from cd5fa3a to 2862aed Compare March 14, 2025 21:34
@MrAlias MrAlias marked this pull request as ready for review March 14, 2025 21:35
@MrAlias MrAlias requested a review from a team as a code owner March 14, 2025 21:35
RonFed
RonFed approved these changes Mar 15, 2025
View reviewed changes
Copy link
Contributor

@RonFed RonFed left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🥇

@MrAlias MrAlias force-pushed the test-load-with-mocks branch from 2862aed to cb314e5 Compare March 15, 2025 14:36
@MrAlias MrAlias merged commit 4ade167 into open-telemetry:main Mar 15, 2025
37 checks passed
@MrAlias MrAlias deleted the test-load-with-mocks branch March 15, 2025 14:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RonFed RonFed RonFed approved these changes

Assignees
No one assigned
Labels
Skip Changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MrAlias @RonFed